Add flamegraph for some benchmarks #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyCpp
reviewed
Jun 27, 2024
Comment on lines
+177
to
+188
| #[cfg(not(target_os = "windows"))] | ||
| criterion_group! { | ||
| name = benches; | ||
| config = Criterion::default().with_profiler(PProfProfiler::new(100, Output::Flamegraph(None))); | ||
| targets = criterion_benchmark | ||
| } | ||
| #[cfg(target_os = "windows")] | ||
| criterion_group! { | ||
| name = benches; | ||
| config = Criterion::default(); | ||
| targets = criterion_benchmark | ||
| } |
There was a problem hiding this comment.
May be we can use https://crates.io/crates/cfg-if to make things easier. Especially in dev tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 122 122
Lines 20279 20279
=====================================
Hits 15211 15211
Misses 5068 5068 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get flamegraphs. Only done for couple of benchmarks which are in the area actively being worked on.